Skip to content

Finalize RC release notes link and rector-typed terminal closure#524

Merged
armanist merged 1 commit into
softberg:masterfrom
armanist:release/3.0.0-rc.1
May 15, 2026
Merged

Finalize RC release notes link and rector-typed terminal closure#524
armanist merged 1 commit into
softberg:masterfrom
armanist:release/3.0.0-rc.1

Conversation

@armanist
Copy link
Copy Markdown
Member

@armanist armanist commented May 15, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Documentation
    • Added "Upgrade guide" link to the 3.0.0 changelog entry for easier access to migration instructions
    • Updated breaking-change documentation for routing configurations

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a26e4271-fb5f-4585-8a53-dece64aa8ef2

📥 Commits

Reviewing files that changed from the base of the PR and between 1b14fce and bbc39a4.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/App/Adapters/WebAppAdapter.php
📝 Walkthrough

Walkthrough

The PR removes ModuleException handling from WebAppAdapter, replaces it with ConfigException, and adds explicit type hints to the terminal request/response callable. The changelog is updated with an upgrade guide link and a routing breaking-change note is removed.

Changes

WebAppAdapter refactoring and documentation

Layer / File(s) Summary
Changelog documentation updates
CHANGELOG.md		 Upgrade guide link added to version 3.0.0 (TBD); routing breaking-change note about nested route groups removed.
WebAppAdapter import and type safety updates
src/App/Adapters/WebAppAdapter.php		 ModuleException import replaced with ConfigException; Request and Response imports added; @throws docblock updated to remove ModuleException; $terminal callable parameter and return type explicitly typed as Request $request: Response.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Type hints bloom like carrots in spring,
Exceptions swapped, new safety we bring,
The changelog sings of guides up ahead,
Nested route groups rest, their farewells said,
Hop along, code flows cleaner instead! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the two main changes: adding the RC release notes link to the changelog and type-hinting the terminal closure parameter.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (1b14fce) to head (bbc39a4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #524   +/-   ##
=========================================
  Coverage     90.87%   90.87%           
  Complexity     3070     3070           
=========================================
  Files           263      263           
  Lines          8100     8100           
=========================================
  Hits           7361     7361           
  Misses          739      739

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanist armanist added this to the 3.0.0 milestone May 15, 2026
@armanist armanist merged commit 3f32957 into softberg:master May 15, 2026
6 of 7 checks passed
@armanist armanist deleted the release/3.0.0-rc.1 branch May 15, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@armanist